Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 add a solution to join cluster through proxy server #311

Merged

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Nov 10, 2023

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from mikeshng and qiujian16 November 10, 2023 05:51
@elgnay
Copy link
Contributor Author

elgnay commented Nov 10, 2023

/hold

@elgnay elgnay force-pushed the join-through-proxy branch from f632daf to 64e8d21 Compare November 10, 2023 06:30
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elgnay
Copy link
Contributor Author

elgnay commented Nov 13, 2023

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 29ffff0 into open-cluster-management-io:main Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants