select clusters with CEL expressions #137
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haoqing0110 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - Variable `managedCluster` will be added. | ||
| The input types may either be instances of `proto.Message` or `ref.Type`. Since OCM API does not implement `proto.Message`, we will add a function called ConvertManagedCluster() to convert ManagedCluster to a Map as an easier way to get started. | ||
|
|
||
| - Function `score` will be added. |
There was a problem hiding this comment.
Need to enhance AddonPlacementScore to add original score value. And aeed a more appropriate name than score.
| - requiredClusterSelector: | ||
| celSelector: | ||
| celExpressions: | ||
| - managedCluster.metadata.labels["version"].versionIsGreaterThan("1.30.0") |
There was a problem hiding this comment.
what kind of version does it support? only semVersion? What if the value is "v0.13.1"?
There was a problem hiding this comment.
Should support both Semantic Versioning and v as a prefix, will update the detail in the proposal.
There was a problem hiding this comment.
how about we change this example using managedCluster.Status.version.kubernetes instead?
| - requiredClusterSelector: | ||
| celSelector: | ||
| celExpressions: | ||
| - managedCluster.score("default, "cpuAvailable") < 2 |
There was a problem hiding this comment.
could we do like managedCluster.score.default.cpuAvailable? or we have to use a function here?
There was a problem hiding this comment.
managedCluster does not have a score field so if we pass managedCluster.score.default.cpuAvailable to the cel for evaluation, it can not recognize it.
Maybe we can use something like managedCluster.score(default).cpuAvailable. function score("crname") will return a map of [scorename]scorevalue, and user can use standard cel expression to select it.
There was a problem hiding this comment.
what if we do clusterScore instead of managedCluster instead? will it work?
There was a problem hiding this comment.
Hmm, have considered about this, when evaluate a expression is true or false, the clusterScore may still need a cluster name as input, managedCluster.score("default") equals to score(managedCluster, "default") (but can not write a cel expression like this).
haoqing0110
force-pushed
the
br_cel
branch
3 times, most recently
from
827317d to
70b2aa8
Compare
Signed-off-by: Qing Hao <[email protected]>
|
|
||
| // Quantity defines the original value of the score. | ||
| // +optional | ||
| Quantity resource.Quantity `json:"quantity"` |
There was a problem hiding this comment.
this could be quite noisy, brings frequent update on the API. We would need to consider how this should be rate limited.
| - requiredClusterSelector: | ||
| celSelector: | ||
| celExpressions: | ||
| - managedCluster.metadata.labels["version"].versionIsGreaterThan("1.30.0") |
There was a problem hiding this comment.
how about we change this example using managedCluster.Status.version.kubernetes instead?
ref: #136