DeschampsThomasSobook - check file integrity #28
Conversation
Dominick-Peluso-Bose
commented
Sep 4, 2019
Dominick-Peluso-Bose
commented
- Better log (called with a function) => readability/easy to improve later
- Some minor fixes in test and syntax (space, simple/double quote...)
- Added a "check file integrity" function => return true if file exist and file has arrived
- Added time parameters for "Has arrived" and "TimeFired"
Better log (called with a function) => readability/easy to improve later Some minor fixes in test and syntax (space, simple/double quote...) Added a "check file integrity" function => return true if file exist and file has arrived Added time parameters for "Has arrived" and "TimeFired"
| //STAGING | ||
| //Replacement for old log | ||
| function debugLog(s, message) { | ||
| const debug = s.getPropertyValue("Debug") === "Yes" |
There was a problem hiding this comment.
Wow, SwitchScripter has changed, huh? Is it using ES6 now?
There was a problem hiding this comment.
Hmm... the scripter manual says it still only supports a partial implementation of ES4... Not sure how you can use const then.
| function debugLog(s, message) { | ||
| const debug = s.getPropertyValue("Debug") === "Yes" | ||
| if (debug === true) { | ||
| s.log(1, message); |
There was a problem hiding this comment.
Do you need to do this? When I used Switch a long time ago, it supported log levels. So you could always log to debug and it would only propagate to the logger is the system enabled debug logging globally on the system.
There was a problem hiding this comment.
Changed in a new version, loggin is back to -1
|
|
||
| //Check if file exist and has arrived | ||
| function isFileUsable (s, file) { | ||
| const stableTime = s.getPropertyValue("stableTime"); |
There was a problem hiding this comment.
Can you update the readme.md with what the stableTime is?
| malformedTicket = File.read(jobTicketPath, "UTF-8"); | ||
| job.log(3, "Malformed ticket: "+ malformedTicket); | ||
| // Fail the dummy job | ||
| job.fail("Job ticket could not be restored and the job could not be processed."); |
There was a problem hiding this comment.
It might be confusing have two of the same log messages in different blocks. For debugging purposes, I'd change this one in some way so you distinguish between the two.
| var tempFolder = channelFolder + getDirectorySeperator(s) + "temp" + getDirectorySeperator(s); | ||
|
|
||
| // Set the timerInterval on start | ||
| var scanInterval = s.getPropertyValue("scanInterval"); |
There was a problem hiding this comment.
Can you update the readme.md with what the scanInterval is?
