Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barahona and Nenes 2007 entraining parcel example (code independent of PySDM, in fact a parcel-model theory tutorial) #1433

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pb475
Copy link

@pb475 pb475 commented Nov 23, 2024

No description provided.

@slayoo slayoo changed the title Barahona and Nenes 2007 entraining example Barahona and Nenes 2007 entraining parcel example (code independent of PySDM, in fact a parcel-model theory tutorial) Nov 24, 2024
@slayoo
Copy link
Member

slayoo commented Nov 25, 2024

@pb475, the notebook committed here is an older version, not the one we cleaned up on Nov 23.
Could you please commit and push the latest version, thanks!

Oops, previous commit was and older version. This is the most up-to-date code for the Barahone-Nenes2007 replication.
@pb475
Copy link
Author

pb475 commented Nov 26, 2024

Thanks for the spot, must have committed an older version. See recent version for up-to-date code.

@slayoo
Copy link
Member

slayoo commented Nov 26, 2024

Thanks!

BTW, here's a simplified version of the notebook I've prepared for students (monodisperse case, without Koehler curve, based on Rogers 1975): #1441

@AgnieszkaZaba
Copy link
Collaborator

I've added badges at the top of the notebook that will worked when merged (obligatory first cell in .ipynb files).
Second cell should be a theoretical description of example (now it's as TODO #1417).

In the third cell we have installation of PySDM-example package for Colab. But here it is not needed.
Maybe we should exclude this file from checking it?

@slayoo
Copy link
Member

slayoo commented Nov 28, 2024

I've added badges at the top of the notebook that will worked when merged (obligatory first cell in .ipynb files). Second cell should be a theoretical description of example (now it's as TODO #1417).

Thank you!

In the third cell we have installation of PySDM-example package for Colab. But here it is not needed. Maybe we should exclude this file from checking it?

I'd keep it for simplicity (i.e., no need to change the test), but also envisaging that we might actually intend to grab some constants values from PySDM.physics and put some of the boilerplate code in .py file for this example, what requires importing from PySDM_examples.Barahona_and_Nenes_2007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants