Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host): Interop optimistic block re-execution hint #983

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 30, 2025

Overview

Adds a hint for the re-execution of optimistic blocks. In the interop proof, during consolidation, this is required to be able to actually fetch the preimages for the optimistic blocks in the reorg case (i.e., where the original L2 block derived from L1 was reorg'd out due to invalid dependencies.)

This method is a bit of a hack, and we're starting to feel the pain of kona-driver's lack of versatility here. The refactor of that crate is tracked in #914, and I'd like to get to that soon, but it's not necessary for this to work. This is much better than the alternative, though, and we can get rid of kona-providers-alloy once again.

@clabby clabby self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.7%. Comparing base (57f59b7) to head (d1e76b3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/driver/src/core.rs 0.0% 10 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review January 30, 2025 18:16
@clabby clabby requested review from refcell and emhane as code owners January 30, 2025 18:16
@refcell refcell merged commit ebdc804 into main Jan 30, 2025
15 of 16 checks passed
@refcell refcell deleted the cl/reexec-hint branch January 30, 2025 19:54
This was referenced Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants