chore: remove unused function in OnlineBlobProvider #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovider Not sure why this was here, as its a private function that wasnt used anywhere in the crate. Also confused me for a while in the beginning, as I kept wondering why the BlobProvider trait (which is meant to be implemented by ClientProvider) was being implemented by a host struct (OnlineBlobProvider). In my mind client and host traits should be separate afaiu.
Needed so that vscode's document formatter respects the rules in rustfmt.toml (which require nightly toolchain)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
refcell
requested changes
Jan 2, 2025
…gs.json this is just to specify for vscode to use nightly version of rustfmt
refcell
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this was here, as its a private function that wasnt used anywhere in the crate anyways.
Also confused me for a while in the beginning, as I kept wondering why the BlobProvider trait (which is meant to be implemented by client structs) was being implemented by a host struct (OnlineBlobProvider). In my mind client and host traits should be separate afaiu?