Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin): Network Subcommand #1300

Merged
merged 3 commits into from
Mar 31, 2025
Merged

feat(bin): Network Subcommand #1300

merged 3 commits into from
Mar 31, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Mar 26, 2025

Description

Wires in RPC server to provide P2P RPC details, introducing a net subcommand to the kona-node binary.

Closes #1311.

@refcell refcell added A-node Area: node crates K-feature Kind: feature labels Mar 26, 2025
@refcell refcell requested review from clabby and emhane as code owners March 26, 2025 02:41
@refcell refcell self-assigned this Mar 26, 2025
@refcell
Copy link
Collaborator Author

refcell commented Mar 26, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell marked this pull request as draft March 26, 2025 02:41
@refcell refcell changed the title chore(node): RPC Wiring feat(node): RPC Wiring Mar 26, 2025
@refcell
Copy link
Collaborator Author

refcell commented Mar 26, 2025

We can merge this and keep iterating if desired, but happy to work in this branch for a bit.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.7%. Comparing base (388b2bd) to head (bd94f68).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/p2p/src/gossip/behaviour.rs 80.0% 1 Missing ⚠️
crates/node/p2p/src/peers/store.rs 0.0% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@refcell refcell force-pushed the rf/rpc-wiring branch 4 times, most recently from 357405d to 819ac21 Compare March 29, 2025 01:03
@refcell refcell changed the title feat(node): RPC Wiring feat(bin): Network Subcommand Mar 29, 2025
@refcell refcell marked this pull request as ready for review March 29, 2025 01:04
@refcell refcell requested a review from emhane March 29, 2025 02:21
@refcell refcell merged commit d3c09cb into main Mar 31, 2025
20 checks passed
@refcell refcell deleted the rf/rpc-wiring branch March 31, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: node crates K-feature Kind: feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(bin/node): Net Subcommand
2 participants