Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use probe-cli v3.19.0 #534

Merged
merged 17 commits into from
Oct 20, 2023
Merged

chore: use probe-cli v3.19.0 #534

merged 17 commits into from
Oct 20, 2023

Conversation

aanorbel
Copy link
Member

Part of ooni/probe#2524

Proposed Changes

@aanorbel
- Enabled riseupcpn and echcheck
ac85484 
- Update Experimental Suite copy
- Add support for saving multiple errors
@aanorbel aanorbel marked this pull request as draft October 16, 2023 07:23
This was linked to issues Oct 16, 2023
mobile: re-add support for riseupvpn ooni/probe#2560
Closed
mobile: add echcheck experiment ooni/probe#2567
Closed
mobile: be prepared for failure during experiment creation ooni/probe#2558
Closed
aanorbel and others added 3 commits October 17, 2023 07:35
@aanorbel
Updated podfile
72c1d84
@aanorbel
Updated version of engine to v3.19.0-alpha.4
22a26c9
@aanorbel
Feat: Add support for http and https proxies (#535)
219a4b8 
Fixes  ooni/probe#2561

## Proposed Changes

- Update support for socks proxy to use dropdown for selecting a scheme.
- Update code to save and retrieve the various proxies.
![Simulator Screenshot - iPhone 15 Pro Max - 2023-10-16 at 15 28
43](https://github.com/ooni/probe-ios/assets/17911892/48a785c2-2849-4c13-aee8-14675c26dad6)
@aanorbel aanorbel marked this pull request as ready for review October 19, 2023 15:33
bassosimone
bassosimone approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 with some small tweaks being requested

ooniprobe/Utility/ProxySettings.m Outdated Show resolved Hide resolved
ooniprobe/Utility/ProxySettings.m Outdated Show resolved Hide resolved
ooniprobe/Utility/ProxySettings.m Outdated Show resolved Hide resolved
ooniprobe/Utility/ProxySettings.m Outdated Show resolved Hide resolved
ooniprobe/Utility/ProxySettings.m Outdated Show resolved Hide resolved
@aanorbel aanorbel linked an issue Oct 20, 2023 that may be closed by this pull request
android: pin to oonimkall using [email protected] ooni/probe#2571
Closed
@aanorbel aanorbel linked an issue Oct 20, 2023 that may be closed by this pull request
ios: pin to oonimkall using [email protected] ooni/probe#2572
Closed
@aanorbel aanorbel removed a link to an issue Oct 20, 2023
android: pin to oonimkall using [email protected] ooni/probe#2571
Closed
@aanorbel aanorbel changed the title chore: use probe-cli v3.19.0-alpha chore: use probe-cli v3.19.0 Oct 20, 2023
@aanorbel aanorbel merged commit beeac1f into master Oct 20, 2023
4 checks passed
@aanorbel aanorbel deleted the issues/2524 branch October 20, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aanorbel @bassosimone