Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing enabledByDefault in echcheck #1655

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix missing enabledByDefault in echcheck #1655

merged 2 commits into from
Oct 15, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Oct 14, 2024

Closes: ooni/probe#2807

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request:
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request:
  • if you changed code inside an experiment, make sure you bump its version number

Description

Please, insert here a more detailed description.

@hellais hellais requested a review from DecFox as a code owner October 14, 2024 14:55
@DecFox DecFox merged commit a66b589 into master Oct 15, 2024
15 of 18 checks passed
@DecFox DecFox deleted the fix-ech branch October 15, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecFox DecFox DecFox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECHCheck is has unitialized enabledByDefault flag
2 participants
@hellais @DecFox