Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poc: rewrite urlgetter using step-by-step #1622

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

poc: rewrite urlgetter using step-by-step #1622

wants to merge 2 commits into from

Commits on Jun 18, 2024

  1. poc: rewrite urlgetter using step-by-step 

    This diff shows how we could incrementally rewrite urlgetter
using a step-by-step measurement style.

Additionally, this diff modifies the facebook_messanger experiment
to show what changes are required to upgrade it.

The general idea of these changes is to incrementally move
experiments away from depending on ./internal/experiment/urlgetter,
and instead use a near drop-in replacement implementation, implemented
in ./internal/urlgetter, which uses step-by-step to measure.

Because ./internal/experiment/urlgetter depends on
./internal/legacy/netx and, instead, ./internal/urlgetter
depends on ./internal/measurexlite, by performing this
kind of migration we make ./internal/legacy/netx unnecessary.

Also, because most users of ./internal/experiment/urlgetter only
use limited functionality, incremental refactoring would be possible.

Reference issue: ooni/probe#2751.
    @bassosimone
    bassosimone committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0f18874 View commit details
    Browse the repository at this point in the history

  2. poc: also convert the telegram experiment

    @bassosimone
    bassosimone committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    282363c View commit details
    Browse the repository at this point in the history