feat(minipipeline): add DNSLookupSuccessWithBogonAddresses (#1449)

This diff adds the DNSLookupSuccessWithBogonAddresses analysis field to minipipeline. We'll need this field to complete ooni/probe#2640. While there, implement `io.Stringer` for the `minipeline.Set` type, which we will also need to have.
ooni · Jan 16, 2024 · dfaeed9 · dfaeed9
1 parent 75780fd
commit dfaeed9
Show file tree

Hide file tree

Showing 72 changed files with 94 additions and 2 deletions.
diff --git a/internal/cmd/minipipeline/testdata/analysis.json b/internal/cmd/minipipeline/testdata/analysis.json
@@ -5,6 +5,7 @@
     2,
     3
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/internal/cmd/minipipeline/testdata/analysis_classic.json b/internal/cmd/minipipeline/testdata/analysis_classic.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     2

diff --git a/internal/minipipeline/analysis.go b/internal/minipipeline/analysis.go
@@ -128,6 +128,9 @@ type WebAnalysis struct {
 	// DNSLookupSuccessWithValidAddress contains DNS transactions with valid IP addresses.
 	DNSLookupSuccessWithValidAddress Set[int64]
 
+	// DNSLookupSuccessWithBogonAddresses contains DNS transactions with bogon IP addresses.
+	DNSLookupSuccessWithBogonAddresses Set[int64]
+
 	// DNSLookupSuccessWithInvalidAddressesClassic is like DNSLookupInvalid but the algorithm is more relaxed
 	// to be compatible with Web Connectivity v0.4's behavior.
 	DNSLookupSuccessWithInvalidAddressesClassic Set[int64]
@@ -224,7 +227,8 @@ type WebAnalysis struct {
 	// HTTPFinalResponseDiffUncommonHeadersIntersection contains the uncommon headers intersection.
 	HTTPFinalResponseDiffUncommonHeadersIntersection optional.Value[map[string]bool]
 
-	// Linear contains the linear analysis.
+	// Linear contains the linear analysis. We only fill this field when using
+	// the [AnalyzeWebObservationsWithLinearAnalysis] constructor.
 	Linear []*WebObservation
 }
 
@@ -246,6 +250,7 @@ func (wa *WebAnalysis) dnsComputeSuccessMetrics(c *WebObservationsContainer) {
 		// if there's a bogon, mark as invalid
 		if !obs.IPAddressBogon.IsNone() && obs.IPAddressBogon.Unwrap() {
 			wa.DNSLookupSuccessWithInvalidAddresses.Add(obs.DNSTransactionID.Unwrap())
+			wa.DNSLookupSuccessWithBogonAddresses.Add(obs.DNSTransactionID.Unwrap())
 			continue
 		}
 

diff --git a/internal/minipipeline/qa_test.go b/internal/minipipeline/qa_test.go
@@ -80,7 +80,7 @@ func testMustRunAllWebTestCases(t *testing.T, topdir string) {
 				//
 				// Note: if tests fail, you likely need to regenerate the static test
 				// cases using ./script/updateminipipeline.bash and you should also eyeball
-				// the diff for these fails to see if it makes sense.
+				// the diff for these changes to see if it makes sense.
 				//
 
 				t.Run("linear consistency checks", func(t *testing.T) {

diff --git a/internal/minipipeline/set.go b/internal/minipipeline/set.go
@@ -2,6 +2,7 @@ package minipipeline
 
 import (
 	"encoding/json"
+	"fmt"
 	"sort"
 )
 
@@ -77,3 +78,8 @@ func (sx *Set[T]) Contains(key T) bool {
 	_, found := sx.state[key]
 	return found
 }
+
+// String implements fmt.Stringer
+func (sx *Set[T]) String() string {
+	return fmt.Sprintf("%v", sx.Keys())
+}
diff --git a/internal/minipipeline/set_test.go b/internal/minipipeline/set_test.go
@@ -115,4 +115,13 @@ func TestSet(t *testing.T) {
 			t.Fatal("expected false")
 		}
 	})
+
+	t.Run("String", func(t *testing.T) {
+		var set Set[int64]
+		set.Add(10, 11, 12, 13)
+		expect := "[10 11 12 13]"
+		if diff := cmp.Diff(expect, set.String()); diff != "" {
+			t.Fatal(diff)
+		}
+	})
 }
diff --git a/...inipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis.json b/...inipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...ine/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis_classic.json b/...ine/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1

diff --git a/...tdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis.json b/...tdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis.json
@@ -5,6 +5,7 @@
     2,
     3
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...bconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis_classic.json b/...bconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1

diff --git a/...ata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis.json b/...ata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis.json
@@ -4,6 +4,7 @@
     2
   ],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     1,
     2

diff --git a/...onnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis_classic.json b/...onnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis_classic.json
@@ -3,6 +3,7 @@
     2
   ],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     2
   ],

diff --git a/...l/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis.json b/...l/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...peline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis_classic.json b/...peline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1

diff --git a/...testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis.json b/...testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [],
   "DNSLookupUnexpectedFailure": [],

diff --git a/.../webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis_classic.json b/.../webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [],
   "DNSLookupUnexpectedFailure": [],

diff --git a/.../testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis.json b/.../testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [],
   "DNSLookupUnexpectedFailure": [],

diff --git a/...a/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis_classic.json b/...a/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis_classic.json
@@ -1,6 +1,7 @@
 {
   "DNSLookupSuccessWithInvalidAddresses": [],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [],
   "DNSLookupUnexpectedFailure": [],

diff --git a/...ipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis.json b/...ipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     2

diff --git a/...testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis_classic.json b/...testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis_classic.json
@@ -1,6 +1,7 @@
 {
   "DNSLookupSuccessWithInvalidAddresses": [],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [],
   "DNSLookupUnexpectedFailure": [

diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis.json
@@ -5,6 +5,9 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [
+    1
+  ],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     1
   ],

diff --git a/...al/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis_classic.json b/...al/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis_classic.json
@@ -3,6 +3,9 @@
     1
   ],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [
+    1
+  ],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     1
   ],

diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1

diff --git a/...minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis_classic.json b/...minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis_classic.json
@@ -1,6 +1,7 @@
 {
   "DNSLookupSuccessWithInvalidAddresses": [],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [],
   "DNSLookupUnexpectedFailure": [

diff --git a/...pipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis.json b/...pipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis.json
@@ -5,6 +5,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     1,
     2

diff --git a/.../testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis_classic.json b/.../testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     2
   ],

diff --git a/...ipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis.json b/...ipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis.json
@@ -5,6 +5,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     1,
     2

diff --git a/...e/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis_classic.json b/...e/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis_classic.json
@@ -3,6 +3,7 @@
     2
   ],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     2
   ],

diff --git a/...minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis.json b/...minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...line/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis_classic.json b/...line/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     2

diff --git a/...l/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis.json b/...l/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...peline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis_classic.json b/...peline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     2

diff --git a/...minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis.json b/...minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis.json
@@ -5,6 +5,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     1,
     2

diff --git a/...line/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis_classic.json b/...line/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis_classic.json
@@ -3,6 +3,7 @@
     2
   ],
   "DNSLookupSuccessWithValidAddress": [],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [
     2
   ],

diff --git a/...ectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis.json b/...ectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/.../generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis_classic.json b/.../generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     2

diff --git a/...ctivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis.json b/...ctivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis_classic.json b/...generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis_classic.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     2

diff --git a/...nnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis.json b/...nnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...ty/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis_classic.json b/...ty/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis_classic.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1

diff --git a/...nectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis.json b/...nectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...y/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis_classic.json b/...y/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     1
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1

diff --git a/...stdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis.json b/...stdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,

diff --git a/...ebconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis_classic.json b/...ebconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis_classic.json
@@ -3,6 +3,7 @@
   "DNSLookupSuccessWithValidAddress": [
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     2

diff --git a/...tdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis.json b/...tdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis.json
@@ -4,6 +4,7 @@
     1,
     2
   ],
+  "DNSLookupSuccessWithBogonAddresses": [],
   "DNSLookupSuccessWithInvalidAddressesClassic": [],
   "DNSLookupSuccessWithValidAddressClassic": [
     1,