Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (OONI Run V2) Add descriptor flow update #695

Merged
merged 3 commits into from
Mar 21, 2024
Merged

feat: (OONI Run V2) Add descriptor flow update #695

merged 3 commits into from
Mar 21, 2024

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Mar 16, 2024 •
edited
Loading

Proposed Changes

  • Add missing post-load toast from install link flow
  • Add 'cancel' button on link install flow.
  • Change 'add link' to 'install link' in new link install flow.
  • Add Link cancellation toast missing.
. . .
Screenshot_20240316_135514 Screenshot_20240316_143418 Screenshot_20240316_145934

@aanorbel aanorbel changed the title Fixes/run v2 add descriptor flow feat: (OONI Run V2) Add descriptor flow update Mar 16, 2024
bassosimone
bassosimone approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

Base automatically changed from issues/2594 to dev/ooni-run-v2 March 21, 2024 14:50
@aanorbel aanorbel changed the base branch from dev/ooni-run-v2 to issues/2594 March 21, 2024 15:17
@aanorbel aanorbel merged commit 8e23e83 into issues/2594 Mar 21, 2024
3 of 6 checks passed
@aanorbel aanorbel deleted the fixes/run-v2-add-descriptor-flow branch March 21, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanorbel @bassosimone