-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update the entry point for ooni run v2 to use load using a different screen #657
feat: Update the entry point for ooni run v2 to use load using a different screen #657
Conversation
…oni/probe-android into issues/2595-loading-screen-entry-point
…es `MainActivity` when closed
We should take care of this failure in
There is also this error in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐳 with request to apply minor changes and to fix broken tests
* A v2 link has the following format: | ||
* | ||
* 1. ooni://runv2/link_id | ||
* 2. https://run.test.ooni.org/v2/link_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we anticipate to always support run.test
or are we going to switch to only run.ooni.org
in the future? In the former case, I'd proactively document both; in the latter I'd just document run.ooni.org
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has not been discussed int the past. the final resting domain for OONI Run V2 has not been discussed. I am not sure at the moment what it would be changed to in the future.
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Outdated
Show resolved
Hide resolved
activityComponent.inject(this) | ||
binding = ActivityOoniRunV2Binding.inflate(layoutInflater) | ||
setContentView(binding.root) | ||
onNewIntent(intent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is intent
declared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intent is declared in the activity that it inherits.
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/activity/oonirun/OoniRunV2Activity.kt
Show resolved
Hide resolved
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <[email protected]>
Proposed Changes
OoniRunV2Activity
to handle all incoming OONI Run v2Intents
AndroidManifest.xml
to launchOoniRunV2Activity
when OONI Run v2Intents
are received.MainActivity
onBackPressed
andfinish
inAddDescriptorActivity
to ensure activity always launchesMainActivity
when closed- Merge with
AddDescriptorActivity
to make a single activity with 2 fragments for each of the views (requires a bit of core rewrite).