Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update the entry point for ooni run v2 to use load using a different screen #657

Merged
merged 13 commits into from
Feb 13, 2024

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Jan 25, 2024

Proposed Changes

  • Add OoniRunV2Activity to handle all incoming OONI Run v2 Intents
  • Update AndroidManifest.xml to launch OoniRunV2Activity when OONI Run v2 Intents are received.
  • Clean MainActivity
  • Override onBackPressed and finish in AddDescriptorActivity to ensure activity always launches MainActivity when closed
. Possible Areas of Improvement
Screenshot_20240125_205311 -Improve on error messages.
- Merge with AddDescriptorActivity to make a single activity with 2 fragments for each of the views (requires a bit of core rewrite).

@aanorbel aanorbel changed the title feat: Updated the entry point for ooni run v2 to use loadinff screen feat: Update the entry point for ooni run v2 to use load in ff screen Jan 25, 2024
@aanorbel aanorbel changed the title feat: Update the entry point for ooni run v2 to use load in ff screen feat: Update the entry point for ooni run v2 to use load using a different screen Jan 25, 2024
@bassosimone
Copy link
Contributor

We should take care of this failure in test / test (push):

org.openobservatory.ooniprobe.test.suite.AbstractSuiteTest > getSuiteTest FAILED
    java.lang.NullPointerException at AbstractSuiteTest.java:96

org.openobservatory.ooniprobe.test.suite.ExperimentalSuiteTest > initializationError FAILED
    org.junit.runners.model.InvalidTestClassError at ParentRunner.java:525

There is also this error in emulator / test:

> Task :app:compileStableFullDebugAndroidTestJavaWithJavac FAILED
The following annotation processors are not incremental: dbflow-processor-4.2.4.jar (com.github.Raizlabs.DBFlow:dbflow-processor:4.2.4).
Make sure all annotation processors are incremental to improve your build speed.
/Users/runner/work/probe-android/probe-android/app/src/androidTest/java/org/openobservatory/ooniprobe/ui/resultdetails/WebsitesTest.java:17: error: cannot find symbol
import org.openobservatory.ooniprobe.test.suite.WebsitesSuite;
                                               ^
  symbol:   class WebsitesSuite
  location: package org.openobservatory.ooniprobe.test.suite
Note: /Users/runner/work/probe-android/probe-android/app/src/androidTest/java/org/openobservatory/ooniprobe/ui/resultdetails/PerformanceTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 with request to apply minor changes and to fix broken tests

* A v2 link has the following format:
*
* 1. ooni://runv2/link_id
* 2. https://run.test.ooni.org/v2/link_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we anticipate to always support run.test or are we going to switch to only run.ooni.org in the future? In the former case, I'd proactively document both; in the latter I'd just document run.ooni.org.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been discussed int the past. the final resting domain for OONI Run V2 has not been discussed. I am not sure at the moment what it would be changed to in the future.

activityComponent.inject(this)
binding = ActivityOoniRunV2Binding.inflate(layoutInflater)
setContentView(binding.root)
onNewIntent(intent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is intent declared?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent is declared in the activity that it inherits.

@aanorbel aanorbel merged commit d096681 into issues/2595 Feb 13, 2024
4 of 6 checks passed
@aanorbel aanorbel deleted the issues/2595-loading-screen-entry-point branch February 13, 2024 14:16
@aanorbel aanorbel mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants