Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove remaining references to butterknife #618

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Chore: Remove remaining references to butterknife #618

merged 1 commit into from
Oct 6, 2023

Conversation

aanorbel
Copy link
Member

Fixes ooni/probe#1709

Proposed Changes

  • Remove butterknife dependency.
  • Remove usage left in code.

@aanorbel aanorbel mentioned this pull request Aug 28, 2023
Closed
38 tasks
bassosimone
bassosimone approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aanorbel aanorbel merged commit 1972bf1 into master Oct 6, 2023
5 checks passed
@aanorbel aanorbel deleted the issues/1709/final branch October 6, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

android: butterknife is deprecated
2 participants
@aanorbel @bassosimone