Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tor and torsf proxies #584

Closed
wants to merge 2 commits into from
Closed

feat: support tor and torsf proxies #584

wants to merge 2 commits into from

Conversation

bassosimone
Copy link
Contributor

Unfortunately, because of ooni/probe#2406, we are going to see crashes when using these proxies.

This diff is part of ooni/probe#2500. Since we're increasingly being blocked, it makes sense to exposes all the possible proxies we can feature.

We're going to touch upon the same files again once we land the ooni/probe-cli#1162 pull request.

Unfortunately, because of ooni/probe#2406, we
are going to see crashes when using these proxies.

This diff is part of ooni/probe#2500. Since we're
increasingly being blocked, it makes sense to exposes all the possible
proxies we can feature.

We're going to touch upon the same files again once we land the
ooni/probe-cli#1162 pull request.
@hellais hellais requested a review from aanorbel August 7, 2023 09:49
aanorbel
aanorbel previously approved these changes Oct 12, 2023
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aanorbel aanorbel self-requested a review October 12, 2023 13:25
@aanorbel
Copy link
Member

Proxies not functioning. More testing required

@aanorbel aanorbel dismissed their stale review October 12, 2023 13:26

Not functioning consistently.

@aanorbel aanorbel marked this pull request as draft October 12, 2023 15:37
@aanorbel aanorbel marked this pull request as ready for review October 16, 2023 19:44
@aanorbel aanorbel marked this pull request as draft October 18, 2023 17:09
@bassosimone
Copy link
Contributor Author

As I realized in https://gitlab.torproject.org/tpo/core/tor/-/issues/40774#note_2959394, if we use tor for circumvention, we cannot use it for measuring, until we use Arti. The issue is that tor_main uses static variables, so two concurrent invocations of tor_main create spectacular opportunities for data races. In light of this, I am going to close this PR and update the relevant issue. We can always pick this PR up at a later time and adapt it into another PR, when we switch to using Arti.

@bassosimone bassosimone deleted the torsf branch October 31, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants