Feat: OONI Run v2 API Bootstrap #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesnt provide one
…ub.com:ooni/probe-android into xoonirun
…ub.com:ooni/probe-android into xoonirun
…hub.com:ooni/probe-android into xoonirun
aanorbel
commented
Aug 4, 2023
Comment on lines
44
to
46
| viewHolder.name.setText(extra.getTestSuite().getTitle()); | ||
| viewHolder.icon.setImageDrawable(viewHolder.itemView.getContext().getDrawable(extra.getTestSuite().getIconGradient())); | ||
| viewHolder.icon.setColorFilter(viewHolder.itemView.getResources().getColor(R.color.color_gray7)); |
There was a problem hiding this comment.
Updates the result row to display Icon provided by the descriptor.
aanorbel
commented
Aug 4, 2023
Comment on lines
+80
to
+87
| return (icon > 0) ? icon : R.drawable.ooni_empty_state; | ||
| } | ||
|
|
||
| public int getIconGradient() { | ||
| if(Build.VERSION.SDK_INT <= Build.VERSION_CODES.M){ | ||
| return icon; | ||
| return (icon > 0) ? icon : R.drawable.ooni_empty_state; | ||
| }else{ | ||
| return icon_24; | ||
| return (icon_24 > 0) ? icon_24 : R.drawable.ooni_empty_state; |
There was a problem hiding this comment.
Set default drawable for descriptors that dont provide one.
aanorbel
commented
Aug 4, 2023
Comment on lines
+149
to
+153
| ## Importing Icons | ||
|
|
||
| ```shell | ||
| ./scripts/import_icons.sh ~/Downloads/react-icons-xmls | ||
| ``` |
There was a problem hiding this comment.
Import xmls from https://github.com/ooni/react-icons/ Build assets https://github.com/ooni/react-icons/actions/runs/5749585726
aanorbel
commented
Aug 4, 2023
aanorbel
changed the title
Related to #598
aanorbel
changed the title
…/add-autorun-and-auto-update-options
…/add-autorun-and-auto-update-options
…-options Feat Run V2: Implement auto run and auto update
…urementDetailActivity` - Customize xml with new attributes for color and animation
…oesnt provide any
…nimation Feat OONI Run V2: Add support for `color` and `animation`
Adds `ooni_run_link_id` to annotations
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: ooni/probe#2471
CLI : ooni/probe-cli#1176
Testing Guide
Ensure OONI Run v1 is working properly.
OONI Run v2 tests
WebConnectivitytestAutomatic Updatesfor the descriptorAutomated testingfor the descriptorInstallTest overview screenTest overview screenDashboard screenTest result screenshows a row with the test name.