updated code based on review

ooni · Oct 13, 2023 · 2b69a13 · 2b69a13
1 parent a6b2733
commit 2b69a13
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/src/main/java/org/openobservatory/ooniprobe/common/ProxySettings.java b/app/src/main/java/org/openobservatory/ooniprobe/common/ProxySettings.java
@@ -83,9 +83,9 @@ public String getProxyString() throws URISyntaxException {
         if (protocol == ProxyProtocol.SOCKS5||protocol == ProxyProtocol.HTTP||protocol == ProxyProtocol.HTTPS) {
             // Alright, we now need to construct a new SOCKS5 URL. We are going to defer
             // doing that to the Java standard library (er, the Android stdlib).
-            String urlStr = protocol+"://" + hostname + ":" + port + "/";
+            String urlStr = protocol.getProtocol()+"://" + hostname + ":" + port + "/";
             if (isIPv6(hostname)) {
-                urlStr = protocol+"://[" + hostname + "]:" + port + "/"; // IPv6 must be quoted in URLs
+                urlStr = protocol.getProtocol()+"://[" + hostname + "]:" + port + "/"; // IPv6 must be quoted in URLs
             }
             URI url = new URI(urlStr);
             return url.toASCIIString();