Skip to content

Commit

Permalink
remove on handshake done from interface
Browse files Browse the repository at this point in the history
  • Loading branch information
ainghazal committed Feb 11, 2024
1 parent fef4a84 commit 93331de
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
3 changes: 0 additions & 3 deletions internal/model/trace.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ type HandshakeTracer interface {

// OnDroppedPacket is called whenever a packet is dropped (in/out)
OnDroppedPacket(direction Direction, stage int, packet *Packet)

// OnHandshakeDone is called when we have completed a handshake.
OnHandshakeDone(remoteAddr string)
}

// Direction is one of two directions on a packet.
Expand Down
5 changes: 0 additions & 5 deletions pkg/tracex/trace.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,6 @@ func (t *Tracer) OnDroppedPacket(direction model.Direction, stage int, packet *m
t.events = append(t.events, e)
}

func (t *Tracer) OnHandshakeDone(remoteAddr string) {
panic("not implemented") // TODO: Implement - when received IP from server.
}

// Trace returns a structured log containing a copy of the array of [model.HandshakeEvent].
func (t *Tracer) Trace() []*event {
t.mu.Lock()
Expand Down Expand Up @@ -199,7 +195,6 @@ type LoggedPacket struct {
PayloadSize int

// Retries keeps track of packet retransmission (only for outgoing packets).
// TODO: use optional here.
Retries optional.Value[int]
}

Expand Down

0 comments on commit 93331de

Please sign in to comment.