Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing a list to filters in list_measurements #929

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

hynnot
Copy link
Contributor

@hynnot hynnot commented Jan 27, 2025

This PR is about the issue #795

Steps:

  • Changes to accept the following filters as lists (domain, test_name, probe_cc, probe_asn)

Notes:

  • Fix a problem with scores type.
  • Fix a problem with the input variable.

@hynnot hynnot requested a review from hellais January 27, 2025 15:29
@hynnot hynnot force-pushed the add-support-for-passing-a-list-to-filters branch from 4b889a7 to d4398d9 Compare January 28, 2025 09:43
@hynnot hynnot marked this pull request as ready for review January 28, 2025 09:47
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think you can merge it when the issue with one of the tests is addressed.

@hellais hellais self-requested a review February 3, 2025 10:53
@hellais
Copy link
Member

hellais commented Feb 3, 2025

We realised in debugging this with @hynnot that input is none in the result listing:

             {'anomaly': False,
              'confirmed': False,
              'failure': False,
              'input': None,
              'measurement_start_time': '2021-07-09T19:14:20.000000Z',
              'measurement_uid': '20210709191422.444165_IT_webconnectivity_21a07ef7982fec55',

Which makes it not possible to test effectively the domain filtering. We should first investigate why it's None and then fix the domain filtering test.

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hynnot hynnot merged commit 04b87ab into master Feb 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants