Fix tests for legacy API #843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the function into the unittest to use it as test
Checking for hardcoded int values for analysis is very brittle, since the analysis might change (as it has) and all the numbers need to be manually updated. Instead we check for reasonable ranges of values that are less likely to change in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the unused round_robin function and the functional test for it
Move the function into the unittest to use it as test
Do not hardcode analysis outcomes in integration tests
Checking for hardcoded int values for analysis is very brittle, since
the analysis might change (as it has) and all the numbers need to be
manually updated.
Instead we check for reasonable ranges of values that are less likely to
change in the future.