Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle and gradle plugin (launch4j) version upgrades (with some gradle refactoring) #108

Closed
wants to merge 2 commits into from

Conversation

dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Mar 31, 2022

details:

  • gradle: 6.8.2 -->> 7.4.2
  • 'launch4j' plugin: 2.4.9 -->> 2.5.2
  • gradle 'shadow' plugin is introduced
  • gradle configurations are changed (this was a prerequisite for a gradle version 6 to 7 upgrade):
    ** 'compile' is replaced with 'implementation'
    ** 'testCompile' is replaced with 'testImplementation'

…e refactoring)

details:
   * gradle:          6.8.2 -->> 7.4.2
   * 'launch4j' plugin: 2.4.9 -->> 2.5.2
   * gradle 'shadow' plugin is introduced
   * gradle configuration are changed (this was a prerequisite for a gradle version 6 to 7 upgrade):
      ** 'compile' is replaced with 'implementation'
      ** 'testCompile' is replaced with 'testImplementation'
@dejan2609
Copy link
Contributor Author

@onyxbits feel free to review.

Notes:

  • I did quite a few of tests with both *.exe and *.jar file on Windows (and I will do the same on Linux/Mac asap)
  • keep in mind that this change is quite large (on the inside, that is, but on the outside things should run in a same way given a fact that project dependencies versions are not changed)

@dejan2609 dejan2609 marked this pull request as draft October 27, 2023 11:15
@dejan2609
Copy link
Contributor Author

Closed in favor of #129

@dejan2609 dejan2609 closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant