ratelimited slack client.conversations_list poorman solution #4094
+87
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When configuring a Slack Bot, Onyx try to list all public/private slack channels, to let you propose on which slack channel(s) you want to configure Onyx.
The problem is that on big Slack workspace (in my case there are > 4000 public/private slack channels), the
client.conversations_list
returns very quickly the first ~ 1000 slack channels, but face a rate limiting issue after that.The proposed solution is not a prodution-ready solution, but it is a "poor man" solution:
How Has This Been Tested?
It was tested on our company workspace, which contains > 4000 slack channels. It "works" but the cold start takes ~ 30 minutes to get the list of all channels.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.