Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat image upload double read #3889

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix chat image upload double read #3889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions backend/onyx/server/query_and_chat/chat_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,8 +713,6 @@ def upload_files_for_chat(
else ChatFileType.PLAIN_TEXT
)

file_content = file.file.read() # Read the file content

if file_type == ChatFileType.IMAGE:
file_content_io = file.file
# NOTE: Image conversion to JPEG used to be enforced here.
Expand All @@ -723,7 +721,7 @@ def upload_files_for_chat(
# 2. Maintain transparency in formats like PNG
# 3. Ameliorate issue with file conversion
else:
file_content_io = io.BytesIO(file_content)
file_content_io = io.BytesIO(file.file.read())

new_content_type = file.content_type

Expand All @@ -741,7 +739,7 @@ def upload_files_for_chat(
# to re-extract it every time we send a message
if file_type == ChatFileType.DOC:
extracted_text = extract_file_text(
file=io.BytesIO(file_content), # use the bytes we already read
file=file_content_io, # use the bytes we already read
file_name=file.filename or "",
)
text_file_id = str(uuid.uuid4())
Expand Down
Loading