Replace styled-components with emotion #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 11 11
Lines 156 156
Branches 22 22
=======================================
Hits 150 150
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
|
Superseeded by #236. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #224
We need to choose if we want to use emotion with or without the babel plugin.
Not using the plugin is less complicated, but also lacks some features. Using the plugin requires us to either eject or use
react-app-rewired, which makes the updating packages potentially more error-prone (esp. updates to babel and react-scripts).This branch contains both options (the first two commits use the plugin +
react-app-rewired) and after that I removed the plugin (because I then learned that the plugin is optional 🙄 ).Personally I would go without the babel plugin for now and if we need or want it later on (or if we need
react-app-rewiredat some point for something else) we can add it relatively easily