change interface{} to any and update to go 1.20

[ehsandavari]

No description provided.

[blgm]

I think this is the right direction, but there is an issue around timing. Go 1.19 is still in support, and many folks are on older versions. Although Ginkgo only supports the Go versions in support, in the past we have tried not to break folks who are a little out of date where the cost of doing that is low.

• any was introduced in Go 1.18, so my personal opinion is that it would be ok to merge this part
• As Go 1.19 is still in support, I'd suggest that the update to Go 1.20 is not merged at this stage because it would break some people and doesn't introduce any advantage. Eventually we will need this, but I don't think we need it yet.

But these are my personal opinions, and @onsi is the maintainer of this project.

[onsi]

hey @ehsandavari thanks for this - I agree with @blgm

dropping interface{} for any makes sense and the timing is right. We should hold off on any changes that require 1.20 until 1.19 is out of support.

[deining]

hey @ehsandavari thanks for this - I agree with @blgm

dropping interface{} for any makes sense and the timing is right. We should hold off on any changes that require 1.20 until 1.19 is out of support.

Support for go 1.19 ended 1 year and 3 months ago (06 Sep 2023). Any chance to get this merged?

[onsi]

I'm good with that but we'll need a fresh PR. are you up for submitting one?

[blgm]

It’s a shame that gofmt doesn’t just do this for you…

[deining]

I'm good with that but we'll need a fresh PR.

Great.

are you up for submitting one?

Yes, see my PR #1502.

[blgm]

Resolved by #1502

[blgm]

I have created onsi/gomega#814 to make Gomega consistent