Adopt lintrunner and enable github actions lint checks 1/2 #16
Conversation
justinchuby
force-pushed
the
justinchu/lintrunner
branch
from
2a7753d to
b212929
Compare
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
justinchuby
force-pushed
the
justinchu/lintrunner
branch
from
b212929 to
cb05f01
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| @@ -1,7 +1,6 @@ | |||
| [tool.isort] | |||
| profile = "black" | |||
| line_length = 120 | |||
| known_first_party = ["neural_compressor"] | |||
There was a problem hiding this comment.
This is automatic.
| rev: v1.5.0 | ||
| hooks: | ||
| - id: yesqa | ||
| name: Unused noqa |
There was a problem hiding this comment.
This is handled by ruff
|
@justinchuby, Although I got the admin permission, I am not able to install this APP. If the tool is not allowed to be installed, let's remove ".pre-commit-config.yaml" directly. |
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
|
SGTM. Just did |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...nlp/huggingface_model/text_generation/llama/quantization/weight_only/evaluation/evaluator.py
Fixed
Show fixed
Hide fixed
Signed-off-by: Justin Chu <[email protected]>
Type of Change
CI
Description
.pre-commit-config.yaml. Checks can be supported with lintrunner.This is the first of two PRs. The second PR will enable more ruff rules and apply autofixes.
Fixes #5
Expected Behavior & Potential Risk
Auto-formatted code.
How has this PR been tested?
CI
Dependency Change?
+dev dependencies: lintrunner, lintrunner-adapters