Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2281: ctrl + backspace handling in text inputs #2443

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

fiddler
Copy link
Contributor

@fiddler fiddler commented Sep 13, 2020

Issue: The InputText component does not handle ctrl + backspace correctly.

Defect: The key combination has no handler setup.

Fix: Added handlers for <C-BS>. Without a selection, it removes the preceding word. When there is a selection it behaves as if just <BS> was pressed and removes the selection.

PS. Went through the contribution guidelines and hopefully got it mostly right here. Comments/improvements welcome! :)

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2020

CLA assistant check
All committers have signed the CLA.

@bryphe bryphe added the B-license-key Bounty: License Key label Sep 16, 2020
@bryphe
Copy link
Member

bryphe commented Sep 16, 2020

Looks great, @fiddler ! Thanks for thinking through the selection-case and adding the test cases.

Really appreciate the contribution!

@bryphe
Copy link
Member

bryphe commented Sep 16, 2020

Oh, and this would qualify for our license key bounty.

Unfortunately it's not automated yet - but would like to send you a coupon code for it. Are you on twitter or Discord? Can DM you it!

@bryphe bryphe merged commit 41fee77 into onivim:master Sep 16, 2020
@fiddler
Copy link
Contributor Author

fiddler commented Sep 16, 2020

Great that it worked out! No need for a license, I've bought one some time ago so am already good on that front! :)

I have a few more improvements done for handling OSX specific stuff like <D-BS>, <D-a> etc. Do you @bryphe know if someone else is already working on those? I'd love to create a PR for the improvements, but the bulk of work is setting up the tests and don't want to do double work if someone else is already on it.

@bryphe
Copy link
Member

bryphe commented Sep 16, 2020

Great that it worked out! No need for a license, I've bought one some time ago so am already good on that front! :)

Thanks for all the support @fiddler ! Sure thing, really appreciate the contribution 😄

I have a few more improvements done for handling OSX specific stuff like , etc.

This would be great - sounds like it would fix the remainder of issues in #2404 !

Do you @bryphe know if someone else is already working on those?

Good question, thanks for checking - AFAIK, no one is working on those macOS-specific shortcuts. @fanantoxa is looking at issues with copy/paste, but I don't think it overlaps with the macOS-specific shortcuts.

@fiddler
Copy link
Contributor Author

fiddler commented Sep 17, 2020

Ok, great. I'll comment on the #2404 that I'll be working on it!

@fanantoxa
Copy link
Contributor

@fiddler I got fixed focus management here: #2428
So I'm going to add copy/cut keys now.
I don't have any Mac around (And never had on) so I'd need later some help to make hotkeys work for Mac Os.

@fiddler
Copy link
Contributor Author

fiddler commented Oct 7, 2020

Whoops, missed your comment @fanantoxa! Is this still relevant? I can help test/check those. Should be <D-x>, <D-c> `.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-license-key Bounty: License Key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants