-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #2281: ctrl + backspace handling in text inputs #2443
fix #2281: ctrl + backspace handling in text inputs #2443
Conversation
Looks great, @fiddler ! Thanks for thinking through the selection-case and adding the test cases. Really appreciate the contribution! |
Oh, and this would qualify for our license key bounty. Unfortunately it's not automated yet - but would like to send you a coupon code for it. Are you on twitter or Discord? Can DM you it! |
Great that it worked out! No need for a license, I've bought one some time ago so am already good on that front! :) I have a few more improvements done for handling OSX specific stuff like |
Thanks for all the support @fiddler ! Sure thing, really appreciate the contribution 😄
This would be great - sounds like it would fix the remainder of issues in #2404 !
Good question, thanks for checking - AFAIK, no one is working on those macOS-specific shortcuts. @fanantoxa is looking at issues with copy/paste, but I don't think it overlaps with the macOS-specific shortcuts. |
Ok, great. I'll comment on the #2404 that I'll be working on it! |
Whoops, missed your comment @fanantoxa! Is this still relevant? I can help test/check those. Should be |
Issue: The InputText component does not handle ctrl + backspace correctly.
Defect: The key combination has no handler setup.
Fix: Added handlers for
<C-BS>
. Without a selection, it removes the preceding word. When there is a selection it behaves as if just<BS>
was pressed and removes the selection.PS. Went through the contribution guidelines and hopefully got it mostly right here. Comments/improvements welcome! :)