Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into feature/stable-cadence #44

Merged
merged 5 commits into from
May 3, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented May 3, 2024

CI is going to hang because of the CODECOV_TOKEN issue, but as long as we check the "Run Tests" step of CI and it passes, we can merge.

EDIT: codecov token now added, tests will pass

@jribbink jribbink changed the base branch from main to feature/stable-cadence May 3, 2024 15:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (9ccee33) to head (923ea88).
Report is 10 commits behind head on feature/stable-cadence.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence      #44      +/-   ##
==========================================================
- Coverage                   58.60%   58.48%   -0.12%     
==========================================================
  Files                          29       29              
  Lines                        2203     2192      -11     
==========================================================
- Hits                         1291     1282       -9     
+ Misses                        726      724       -2     
  Partials                      186      186              
Flag Coverage Δ
unittests 58.48% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 5e0bf14 into feature/stable-cadence May 3, 2024
2 checks passed
@jribbink jribbink deleted the jribbink/sc-merge-main branch May 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants