Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Storage Refactor] Refactor saving execution results #6906

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

zhangchiqing
Copy link
Member

No description provided.

@zhangchiqing zhangchiqing force-pushed the leo/db-ops-save-execution-results branch from 06c96d0 to f793dcf Compare January 18, 2025 00:45
@zhangchiqing zhangchiqing force-pushed the leo/db-ops-save-execution-results branch from f793dcf to 51b6fa0 Compare January 22, 2025 21:48
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 38.00403% with 615 lines in your changes missing coverage. Please review.

Project coverage is 42.06%. Comparing base (19df94c) to head (9a8f654).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
storage/operation/transaction_results.go 0.00% 94 Missing ⚠️
storage/store/receipts.go 52.50% 28 Missing and 10 partials ⚠️
storage/store/my_receipts.go 54.32% 33 Missing and 4 partials ⚠️
cmd/execution_builder.go 0.00% 33 Missing ⚠️
storage/store/results.go 65.26% 27 Missing and 6 partials ⚠️
storage/store/events.go 25.00% 30 Missing ⚠️
engine/execution/state/state.go 43.13% 22 Missing and 7 partials ⚠️
storage/mocks/storage.go 0.00% 23 Missing ⚠️
engine/testutil/nodes.go 0.00% 22 Missing ⚠️
storage/store/transaction_results.go 54.54% 17 Missing and 3 partials ⚠️
... and 35 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6906      +/-   ##
==========================================
+ Coverage   41.09%   42.06%   +0.97%     
==========================================
  Files        2118     1799     -319     
  Lines      185850   164016   -21834     
==========================================
- Hits        76369    68991    -7378     
+ Misses     103080    89248   -13832     
+ Partials     6401     5777     -624     
Flag Coverage Δ
unittests 42.06% <38.00%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants