Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Verification] Adding block id and height in verified approvals #6402

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

zhangchiqing
Copy link
Member

This PR adds block id and height to the log of verified approval.

@zhangchiqing zhangchiqing force-pushed the leo/log-block-id-height-in-approvals branch from 239f5af to 5a0712a Compare August 26, 2024 22:39
@zhangchiqing zhangchiqing marked this pull request as ready for review August 26, 2024 22:41
@zhangchiqing zhangchiqing requested a review from ramtinms as a code owner August 26, 2024 22:41
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.46%. Comparing base (b93c60f) to head (e76b08f).

Files with missing lines Patch % Lines
engine/verification/verifier/engine.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6402      +/-   ##
==========================================
- Coverage   41.47%   41.46%   -0.01%     
==========================================
  Files        2017     2017              
  Lines      143768   143770       +2     
==========================================
- Hits        59622    59614       -8     
- Misses      77972    77978       +6     
- Partials     6174     6178       +4     
Flag Coverage Δ
unittests 41.46% <93.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like chunk_id is also supposed to be logged, but the logger update isn't saved

log.With().Hex("chunk_id", logging.Entity(ch)).Logger()

@zhangchiqing zhangchiqing force-pushed the leo/log-block-id-height-in-approvals branch from 56529a3 to e76b08f Compare August 29, 2024 01:12
@zhangchiqing zhangchiqing added this pull request to the merge queue Sep 3, 2024
Merged via the queue into master with commit 9f7e8b1 Sep 3, 2024
55 checks passed
@zhangchiqing zhangchiqing deleted the leo/log-block-id-height-in-approvals branch September 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants