Khalil/1899 async rpc sent tracker #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4553 +/- ##
==========================================
+ Coverage 54.44% 54.48% +0.03%
==========================================
Files 912 912
Lines 85165 85253 +88
==========================================
+ Hits 46372 46453 +81
- Misses 35216 35225 +9
+ Partials 3577 3575 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…w/flow-go into khalil/1899-async-rpc-sent-tracker
thep2p
reviewed
Jul 14, 2023
Co-authored-by: Yahya Hassanzadeh, Ph.D. <[email protected]>
Co-authored-by: Yahya Hassanzadeh, Ph.D. <[email protected]>
Co-authored-by: Yahya Hassanzadeh, Ph.D. <[email protected]>
…w/flow-go into khalil/1899-async-rpc-sent-tracker
thep2p
approved these changes
Jul 19, 2023
| if err != nil { | ||
| return fmt.Errorf("failed to get track rpc work nonce: %w", err) | ||
| } | ||
| if ok := t.workerPool.Submit(trackableRPC{Nonce: n, rpc: rpc}); !ok { |
There was a problem hiding this comment.
Please add tests for the following scenarios:
- Duplicate RPCs with different nonce values; both should be processed.
- Distinct RPCs tracked concurrently; a worker should eventually pick each.
peterargue
reviewed
Jul 19, 2023
peterargue
approved these changes
Jul 21, 2023
| // All worker functions will be run in parallel when the ComponentManager is started. | ||
| // Note: AddWorker is not concurrency-safe, and should only be called on an individual builder | ||
| // within a single goroutine. | ||
| // within a single goroutine.// AddWorker adds a ComponentWorker closure to the ComponentManagerBuilder |
There was a problem hiding this comment.
the formatting here is messed up. Can you revert the changes to this file?
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 25, 2023
4553: Khalil/1899 async rpc sent tracker r=kc1116 a=kc1116 This PR adds a worker pool to the gossipsub mesh tracer rpc sent tracker worker pool. RPC control messages are processed synchronously, so it's imperative that any sub-process involved in the processing of RPC's must be non-blocking. This PR also updates the tracker to keep track of the `last highest iHaves size`, this will be used during iWant flooding detection to dynamically update the sample size of iWants expected based on the most recent largest iHaves sent. Further reading: https://github.com/dapperlabs/flow-go/issues/6472 Co-authored-by: Khalil Claybon <[email protected]>
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a worker pool to the gossipsub mesh tracer rpc sent tracker worker pool. RPC control messages are processed synchronously, so it's imperative that any sub-process involved in the processing of RPC's must be non-blocking. This PR also updates the tracker to keep track of the
last highest iHaves size, this will be used during iWant flooding detection to dynamically update the sample size of iWants expected based on the most recent largest iHaves sent.Further reading: https://github.com/dapperlabs/flow-go/issues/6472