-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align BlockSeal type with protobuf schema #780
Merged
franklywatson
merged 6 commits into
onflow:master
from
The-K-R-O-K:illia-malachyn/766-block-seal-response-object
Oct 21, 2024
Merged
align BlockSeal type with protobuf schema #780
franklywatson
merged 6 commits into
onflow:master
from
The-K-R-O-K:illia-malachyn/766-block-seal-response-object
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-malachyn
requested review from
janezpodhostnik,
chasefleming,
nvdtf and
jribbink
as code owners
October 15, 2024 14:57
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #780 +/- ##
==========================================
- Coverage 56.67% 56.65% -0.03%
==========================================
Files 35 35
Lines 6050 7269 +1219
==========================================
+ Hits 3429 4118 +689
- Misses 2127 2657 +530
Partials 494 494
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
Oct 17, 2024
peterargue
approved these changes
Oct 17, 2024
jribbink
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #766