-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API version shown in build details #731
Conversation
WalkthroughThe pull request modifies the Makefile to improve version retrieval during the build process. The key change involves adjusting the Git version command to use Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Closes: #730
Description
There was a regression with the latest changes on the
Makefile
, which ended up showing the commit tag in the build version:instead of the proper tag version, e.g.
v1.0.1
.This is also used in the
web3_clientVersion
JSON-RPC endpoint, and is useful for viewing which version is run by a given EVM Gateway instance.For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit