Update constant for block gas limit

[m-Peter]

Closes: #558

Description

Update the constant's value to 120M, as that is the theoretical block gas limit.

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the standards mentioned here.
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

Summary by CodeRabbit

• New Features

  • Increased the blockGasLimit to support larger transactions.

• Bug Fixes

  • Enhanced test cases to ensure accurate block retrieval and fee history, including gas limit assertions.

[coderabbitai]

Walkthrough

The pull request modifies the blockGasLimit constant in the api/encode_transaction.go file, increasing its value from 15,000,000 to 120,000,000 to support larger transactions. Additionally, enhancements were made to the test cases in tests/web3js/eth_non_interactive_test.js to validate block retrieval and fee history, including assertions related to the new gas limit.

Changes

File	Change Summary
api/encode_transaction.go	Updated blockGasLimit from 15_000_000 to 120_000_000 to accommodate larger transactions.
tests/web3js/eth_non_interactive_test.js	Enhanced test cases for block retrieval and fee history, including assertions for gasLimit.

Assessment against linked issues

Objective	Addressed	Explanation
Gas Limit should be increased to accommodate higher gas usage (558)	✅

Possibly related PRs

• Add request limits for JSON-RPC batch calls #277: Modifications to tests/web3js/eth_non_interactive_test.js indicating potential connections in transaction handling tests.
• Block endpoints with many transactions fail with rate limit error #548: Changes to api/api.go, which may relate to transaction processing and limits, similar to adjustments made in this PR.

Suggested labels

Improvement

Poem

🐰 In the meadow where transactions bloom,
A gas limit raised, dispelling the gloom.
With tests enhanced, we hop with delight,
Validating blocks, our future is bright!
So here's to the changes, let’s cheer and play,
For a smoother tomorrow, hip-hip-hooray! 🎉

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 78467d5 and 72b27dd.

Files selected for processing (2)

• api/encode_transaction.go (1 hunks)
• tests/web3js/eth_non_interactive_test.js (2 hunks)

Additional comments not posted (3)

api/encode_transaction.go (1)

12-12: Verify the rationale behind setting the block gas limit to 120M.

The linked issue #558 suggests increasing the gasLimit to the maximum cap of 30M, given that the gasUsed exceeded 15M of the limit. However, the updated constant value of 120M is significantly higher than the suggested limit.

Please consider the following:

• Provide a clear justification for setting the block gas limit to 120M and ensure it aligns with the system's requirements and constraints.
• Consider using a more conservative limit, such as the 30M mentioned in the linked issue, unless there is a compelling reason for the higher value.
• Conduct thorough testing and validation to assess the impact of the increased gas limit on the system's performance, security, and resource utilization.

tests/web3js/eth_non_interactive_test.js (2)

31-31: LGTM!

The assertion correctly verifies that the block.gasLimit matches the updated value of 120000000n, which aligns with the PR objective of increasing the block gas limit to 120M.

---

383-383: Verify the gasUsedRatio value.

Please ensure that the updated gasUsedRatio value of [0, 0.006205458333333334] is correct and aligns with the expected behavior considering the increased block gas limit. Provide additional context or justification for the change if necessary.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.