Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases utilizing Cadence arch calls #538

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Sep 10, 2024

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Summary by CodeRabbit

  • New Features

    • Enhanced smart contract functionality with new parameters and event emissions.
    • Streamlined function interfaces for improved usability in the Storage contract.
    • Added historical validation for account balances and nonces in EVM interaction tests.
  • Bug Fixes

    • Improved error handling mechanisms for more predictable contract behavior.
  • Tests

    • Expanded test coverage for EVM interactions, ensuring robustness in contract functionality and response accuracy.
    • Enhanced assertions for gas estimation and historical state verification.

@m-Peter m-Peter added this to the Flow-EVM-M2 milestone Sep 10, 2024
@m-Peter m-Peter self-assigned this Sep 10, 2024
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Walkthrough

This pull request introduces significant modifications to smart contract code, focusing on changes to function signatures and internal logic. The Storage contract is simplified by removing parameters from specific functions, enhancing their interfaces. Additionally, the test suite is improved with new assertions for balance and nonce checks, expanding coverage for contract interactions. Updates to event emissions and error handling mechanisms are also included, reflecting a more robust approach to contract functionality and testing.

Changes

Files Change Summary
contracts/SomeContract.sol, tests/fixtures/storage.sol Modifications to function signatures, including added parameters and removed validation checks. New events introduced and existing ones modified.
tests/web3js/build_evm_state_test.js Enhancements to the test suite, adding balance and nonce assertions for an externally owned account (EOA) and expanding transaction submissions for contract methods.

Possibly related PRs

Poem

🐇 In the meadow where contracts play,
Functions dance in a new array.
Events chirp with a joyful sound,
Streamlined paths where logic's found.
With each change, the code does bloom,
Hopping forth, dispelling gloom! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@sideninja sideninja merged commit 016588a into main Sep 13, 2024
2 checks passed
@m-Peter m-Peter deleted the add-tests-for-arch-calls branch September 13, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants