Update to Cadence v1.3.1 #786
Conversation
turbolent
requested review from
janezpodhostnik,
bluesign,
chasefleming,
jribbink and
peterargue
as code owners
|
@joshuahannan Now that the |
|
I agree in principle, but I wouldn't necessarily want to risk breaking any developers' tests that might rely on the feature to deploy storefront. Do you think that we should remove it anyway? |
|
Given that flow-go now always deploys the contract during bootstrapping, it's no longer an option, and the deployment by the Emulator is now an overwrite of the existing contract. See the failing tests. So it's not a question of if, but needs to be done. There is not going to be any impact on developers, the contract continues to be deployed, just simply now by flow-go instead of the Emulator. I thought that was the goal of onflow/flow-go#6611? |
|
It is, I just assumed that the deployment in the emulator was deploying it to a different account. I didn't know that it was deploying it to the same account. I'll make a PR to this branch to remove it |
since onflow/flow-go#6611, flow-go deploys the contract during bootstrapping
|
@joshuahannan Just saw your comment, sorry. I already removed it in 6c9868f and the tests are passing. But feel free to push adjustments or even revert that! |
|
okay. I just made another PR to this branch with some additional changes |
Update comments about storefront
Description
Automatically update to: