Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to compose with other graceland implementations #783

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

bjartek
Copy link
Contributor

@bjartek bjartek commented Jan 28, 2025

A small pr to make it possible to add all the servers in the emulator to another graceland group

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.61%. Comparing base (96c4f80) to head (fbd501a).
Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
- Coverage   35.30%   34.61%   -0.70%     
==========================================
  Files          47       45       -2     
  Lines        7418     7321      -97     
==========================================
- Hits         2619     2534      -85     
+ Misses       4610     4604       -6     
+ Partials      189      183       -6     
Flag Coverage Δ
unittests 34.61% <100.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjartek
Copy link
Contributor Author

bjartek commented Feb 2, 2025

when can this be merged?

@peterargue peterargue enabled auto-merge February 7, 2025 18:17
@peterargue
Copy link
Contributor

when can this be merged?

let's merge it!

@peterargue peterargue merged commit 88c5a70 into onflow:master Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants