Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mobile support #231

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Improve mobile support #231

merged 10 commits into from
Aug 12, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Aug 12, 2024 •
edited
Loading

closes #233
closes #232

  • Adds deep linking for mobile
  • Uses a bottom sheet/drawer on small screen mobile devices
  • General improvements to WalletConnect URI (refresh 1 minute before expiry if possible)
Screenshot 2024-08-12 at 9 23 17 AM

@jribbink jribbink added the v2 label Aug 12, 2024
@jribbink jribbink requested a review from a team as a code owner August 12, 2024 16:24
@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fcl-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 4:28pm

@jribbink jribbink changed the base branch from master to v2 August 12, 2024 16:24
@jribbink jribbink merged commit 0a4d18a into v2 Aug 12, 2024
3 checks passed
@jribbink jribbink deleted the jribbink/deep-link branch August 12, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jribbink @chasefleming