Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nialexsan/v3 best practices #447

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Nialexsan/v3 best practices #447

merged 7 commits into from
Nov 27, 2023

Conversation

nialexsan
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 4:42pm

@nialexsan nialexsan changed the base branch from main to nialexsan/v3-guides-move November 13, 2023 20:06
@Aliserag
Copy link
Contributor

Excellent, tiny tweaks -

Under testing Recommendations in Development Standards let’s also link to our newly created testing guide.

Under anti-patterns, the headers for Security and Robustness as well as Avoid using AuthAccount as a Function Parameter are the same size and it effects readability, can we make Security and Robustness the same size (larger) as other main headers for consistency and readability?

In Design Patterns and Anti-Patterns we start the docs off with text before diving in, can we highlight this in a coloured ‘info’ banner’ similar to what we have in Guides/Flow App Quickstart.

Base automatically changed from nialexsan/v3-guides-move to main November 19, 2023 23:06
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Aliserag Aliserag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, great job!

@nialexsan nialexsan merged commit 6c5514c into main Nov 27, 2023
@nialexsan nialexsan deleted the nialexsan/v3-best-practices branch November 27, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants