Add icons to home page #1128
Merged
Add icons to home page #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
briandoyle81
commented
Feb 5, 2025
briandoyle81
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chasefleming
requested changes
Feb 6, 2025
src/hooks/use-icons.ts
Outdated
| import { useState, useEffect } from 'react'; | ||
|
|
||
| // Direct imports | ||
| import AccessIncredibleIPIcon from '/static/images/icons/Access Incredible IP.svg'; |
There was a problem hiding this comment.
The file names feel inconsistent. Not a good practice to have spaces in file names too.
| @@ -20,6 +25,7 @@ export const buildGridData = { | |||
| 'Cadence is a resource-oriented programming language that makes it easy to build secure, scalable, and composable applications.', | |||
| iconColor: 'green', | |||
| cardColor: 'black', | |||
| icon: 'Flow Cadence', | |||
There was a problem hiding this comment.
Think we need a better naming system for these
chasefleming
reviewed
Feb 6, 2025
src/hooks/use-icons.ts
Outdated
| // Direct imports | ||
| import AccessIncredibleIPIcon from '/static/images/icons/Access Incredible IP.svg'; | ||
| import AccountAbstractionIcon from '/static/images/icons/Account Abstraction.svg'; | ||
| import BatchedEVMTransactionsIcon from '/static/images/icons/Batched EVM Transactions.svg'; |
There was a problem hiding this comment.
You might be able to just import the whole folder if you want.
chasefleming
requested changes
Feb 6, 2025
|
|
||
| interface ActionCardProps { | ||
| icon?: string; |
There was a problem hiding this comment.
This is similar to the optional title thing from the other PR. If you make it optional, can you add a conditional for Icon component/section in the UI.
chasefleming
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.