passing meaningful information into an exception when deserialization… #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… goes wrong. The current message lookend like this: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected STRING but was BEGIN_OBJECT at path $.records[0] We need to get more info to figure out what's the actual issue.
There was a problem hiding this comment.
Hello @zdary , thanks for your contribution but unfortunately it can't be integrated as it's. As in the README file, this kind of change needs to be performed in the template instead since the library is auto-generated.
|
Thank you, I've moved this to onfido/onfido-openapi-spec#152 |
|
@dvacca-onfido Can anyone look at my PR at onfido/onfido-openapi-spec#152 ? Seem like no activity on that repo :( |
@zdary, I apologise for the delay; please bear with us, we'll be back on that very soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… goes wrong.
The current message lookend like this:
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected STRING but was BEGIN_OBJECT at path $.records[0]
We need to get more info to figure out what's the actual issue.