feat: add very large amount support

[nesquikm]

• Updated Money JSON serialization format
• Simplified Money formatting with default pattern
• Improved currency precision calculation
• Added tests for large scale and integer handling
• Enhanced pattern encoding and formatting flexibility

[bsutton]

so the json changes look to be breaking.
Not necessarily a problem but is this an improvement for end users?

[nesquikm]

so the json changes look to be breaking. Not necessarily a problem but is this an improvement for end users?

This is improvement for architecture. What the point having from/to json in Fixed (that works perfectly) and parsing it here as string?

[bsutton]

I'm not certain I would call this an architectural issue given it's one function. It's not exactly going to cause us a maintenance issue. I also always argue in favour of making the users life easier over ours. This change doesn't make our life easier (the existing code works and will require no further maintenance) whilst the change will break user code in places that are hard to fix for them. E.g. if they are storing the json in a db, fixing the db to accommodate this change will be a major pain and one likely to cause runtime errors in production of they miss something.

…

On Sat, 22 Feb 2025, 7:20 pm Mike, ***@***.***> wrote: so the json changes look to be breaking. Not necessarily a problem but is this an improvement for end users? This is improvement for architecture. What the point having from/to json in Fixed (that works perfectly) and parsing it here as string? — Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG32OE5KJ5CMCIO4S4MOYT2RAXLXAVCNFSM6AAAAABXLT4QMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGA4DONBWGE> . You are receiving this because you commented.Message ID: <onepub-dev/money .***@***.***> [image: nesquikm]*nesquikm* left a comment (onepub-dev/money.dart#91) <#91 (comment)> so the json changes look to be breaking. Not necessarily a problem but is this an improvement for end users? This is improvement for architecture. What the point having from/to json in Fixed (that works perfectly) and parsing it here as string? — Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG32OE5KJ5CMCIO4S4MOYT2RAXLXAVCNFSM6AAAAABXLT4QMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGA4DONBWGE> . You are receiving this because you commented.Message ID: <onepub-dev/money .***@***.***>

[nesquikm]

We can wrap Fixed.fromJson(...) in try...catch and, if it fails, call Fixed.parse(...). This will provide seamless migration from existing (stored somewhere) records. What do you think?

[bsutton]

That is certainly better but still leaves users with having to upgrade client/ server systems simultaneously - or at least the reader needs to be updated first. It is also a problem if they are using any third party tools to read the json as they will now have two forms of the json in their db. I'm still struggling to see a benefit of this change that out ways the cost to users.

…

On Tue, 25 Feb 2025, 2:22 am Mike, ***@***.***> wrote: We can wrap Fixed.fromJson(...) in try...catch and, if it fails, call Fixed.parse(...). This will provide seamless migration from existing (stored somewhere) records. What do you think? — Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG32ODSBAJCK7HM4UJX2DT2RM2LRAVCNFSM6AAAAABXLT4QMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYG44DCNZRGA> . You are receiving this because you commented.Message ID: <onepub-dev/money .***@***.***> [image: nesquikm]*nesquikm* left a comment (onepub-dev/money.dart#91) <#91 (comment)> We can wrap Fixed.fromJson(...) in try...catch and, if it fails, call Fixed.parse(...). This will provide seamless migration from existing (stored somewhere) records. What do you think? — Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG32ODSBAJCK7HM4UJX2DT2RM2LRAVCNFSM6AAAAABXLT4QMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYG44DCNZRGA> . You are receiving this because you commented.Message ID: <onepub-dev/money .***@***.***>