hyperscan: replacing wrapper #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nix issues are because poetry2nix not resolving dependencies from custom registry sources. I'll publish the package on pypi, this will clear the remaining errors. |
|
Works like a charm ! |
|
Currently doing a bunch of tests on ARM based platforms. |
|
I am planning to release aarch64 wheels also |
qkaiser
approved these changes
Dec 5, 2022
|
Note: to fix #415 you'll need to publish wheels for aarch64 Linux and OSX. |
I have wheels for OSX, only aarch64 linux wheels are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new wrapper is written by me and comes with a statically linked vectorscan library. Extensive testing and a proper pypi release is needed before this can be merged.
Hopefully this can fix #415 and reduce friction endured during installation like in #467.
Also would help packaging for Nixpkgs (#424) and other distros, as dynamic linking to a system provided hyperscan library is also a possibility.
Currently the only dependency required is C++ runtime (
libstdc++and its mac counterpart) which is much easier to come by.