-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry -> uv #1079
base: main
Are you sure you want to change the base?
Poetry -> uv #1079
Conversation
dd0cdee
to
f681055
Compare
description = "Extract files from any kind of container formats" | ||
license = "MIT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this removed on purpose? The schema linked at the top of the file (https://json.schemastore.org/pyproject.json) allows license
field here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This a draft for a reason, although the license key is for custom license
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although the license key is for custom license
is it ? the doc you linked mentions SPDX explicitly
@@ -13,35 +13,13 @@ runs: | |||
run: sudo unblob/install-deps.sh | |||
shell: bash | |||
|
|||
- name: Setup Python | |||
uses: actions/setup-python@v5 | |||
- name: Install uv & Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick search if any poetry
stuff remained, the things I found:
flake.lock
:poetry2nix
- don't we need to sync the lock file?bug-report-🐞.md
build-publish-image.yml
- actually does somepoetry build
stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use poetry2nix, so it is some garbage.
Somewhere I lost the other changes, hmm.
Custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the move to uv
, but would like to see @kukovecz comments addressed.
It was surprisingly easy.
See #1034 for reasoning.