Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry -> uv #1079

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Poetry -> uv #1079

wants to merge 10 commits into from

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented Jan 13, 2025

It was surprisingly easy.

See #1034 for reasoning.

@vlaci vlaci force-pushed the uv branch 2 times, most recently from dd0cdee to f681055 Compare January 13, 2025 16:48
description = "Extract files from any kind of container formats"
license = "MIT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removed on purpose? The schema linked at the top of the file (https://json.schemastore.org/pyproject.json) allows license field here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a draft for a reason, although the license key is for custom license
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

Copy link
Contributor

@qkaiser qkaiser Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although the license key is for custom license

is it ? the doc you linked mentions SPDX explicitly

@@ -13,35 +13,13 @@ runs:
run: sudo unblob/install-deps.sh
shell: bash

- name: Setup Python
uses: actions/setup-python@v5
- name: Install uv & Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick search if any poetry stuff remained, the things I found:

  • flake.lock: poetry2nix - don't we need to sync the lock file?
  • bug-report-🐞.md
  • build-publish-image.yml - actually does some poetry build stuff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use poetry2nix, so it is some garbage.
Somewhere I lost the other changes, hmm.

@e3krisztian
Copy link
Contributor

Custom direnv code using poetry would break, but that is expected.

https://github.com/direnv/direnv/wiki/Python#uv

direnv/direnv#1250

Copy link
Contributor

@qkaiser qkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the move to uv, but would like to see @kukovecz comments addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants