Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to align CTS and Spec for Program #2697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improvements to align CTS and Spec for Program #2697

wants to merge 1 commit into from

Conversation

martygrant
Copy link
Contributor

@martygrant martygrant commented Feb 12, 2025 •
edited
Loading

  • All error returns for urProgramCreateWithIL are now covered, and a Success case with different properties has been added
  • Passing properties to urProgramCreateWithBinary
  • Added tests for passing options to urProgramCompile
    • Not passing any options to urProgramLink as there are no common platform independent options that I'm aware of
  • Added extra validation for urProgramRetain/Release
  • Added unowned native handle test for urProgramCreateWithNativeHandle

@github-actions github-actions bot added the conformance Conformance test suite issues. label Feb 12, 2025
@martygrant martygrant force-pushed the martin/program-cts-spec-gap branch 3 times, most recently from f7bfaea to b55b8ce Compare February 13, 2025 11:02
@github-actions github-actions bot added the opencl OpenCL adapter specific issues label Feb 13, 2025
@martygrant
Improvements to align CTS and Spec for Program:
258073d 
- All error returns for urProgramCreateWithIL are now covered, and a Success case with different properties has been added
- Passing properties to urProgramCreateWithBinary
- Added tests for passing options to urProgramCompile/Link
- Added extra validation for urProgramRetain/Release
- Added unowned native handle test for urProgramCreateWithNativeHandle
@martygrant martygrant force-pushed the martin/program-cts-spec-gap branch from b55b8ce to 258073d Compare February 14, 2025 16:51
@martygrant martygrant marked this pull request as ready for review February 17, 2025 14:08
@martygrant martygrant requested review from a team as code owners February 17, 2025 14:08
@martygrant
Copy link
Contributor Author

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

This is an automated comment.

@martygrant martygrant mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conformance Conformance test suite issues. opencl OpenCL adapter specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martygrant