Reorganised urEventGetProfilingInfo test into separate tests instead of a switch #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
force-pushed
the
martin/getinfo-property-rename
branch
4 times, most recently
from
b7a32e5 to
fb30178
Compare
14 tasks
RossBrunton
reviewed
Jan 30, 2025
RossBrunton
approved these changes
Jan 30, 2025
martygrant
force-pushed
the
martin/getinfo-property-rename
branch
from
fb30178 to
f2be414
Compare
|
I've added some more changes to this PR, tidying up some more |
martygrant
force-pushed
the
martin/getinfo-property-rename
branch
2 times, most recently
from
a2f7b34 to
a58da89
Compare
…of a switch and rework various urXGetInfo tests: - Housekeeping pass to tidy up tests, renaming and adding consts where appropriate - Added ASSERT_QUERY_RETURNS_VALUE and uur::stringPropertyIsValid helpers from oneapi-src#2597 - Used above helpers across all tests to better validate numerical and char[] queries, and reworked some char[] queries - Removed any non useful checks on vector sizes after passing them into a urXGetInfo query
martygrant
force-pushed
the
martin/getinfo-property-rename
branch
from
a58da89 to
b52be5b
Compare
kbenzie
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2290
Also done a housekeeping pass across all urXGetInfo tests, renaming and adding consts where appropriate, and adding extra checks to tests with vectors.