Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate for the v0.11.6 release tag #2608

Draft
wants to merge 2 commits into
base: v0.11.x
Choose a base branch
from
Draft

Candidate for the v0.11.6 release tag #2608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cb6589
Merge pull request #2503 from omarahmed1111/fix-cuda-uninitialized-event
martygrant Jan 3, 2025
0936073
Set CMake version to v0.11.6
kbenzie Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

cmake_minimum_required(VERSION 3.20.0 FATAL_ERROR)
project(unified-runtime VERSION 0.11.5)
project(unified-runtime VERSION 0.11.6)

# Check if unified runtime is built as a standalone project.
if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR UR_STANDALONE_BUILD)
Expand Down
6 changes: 3 additions & 3 deletions source/adapters/cuda/command_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ commandHandleReleaseInternal(ur_exp_command_buffer_command_handle_t Command) {
// of the `ur_event_t` object doesn't free the underlying CuEvent_t object and
// we need to do it manually ourselves.
if (Command->SignalNode) {
CUevent SignalEvent;
CUevent SignalEvent{};
UR_CHECK_ERROR(
cuGraphEventRecordNodeGetEvent(Command->SignalNode, &SignalEvent));
UR_CHECK_ERROR(cuEventDestroy(SignalEvent));
Expand Down Expand Up @@ -85,7 +85,7 @@ ur_exp_command_buffer_handle_t_::~ur_exp_command_buffer_handle_t_() {
std::unique_ptr<ur_event_handle_t_>
ur_exp_command_buffer_handle_t_::addSignalNode(CUgraphNode DepNode,
CUgraphNode &SignalNode) {
CUevent Event;
CUevent Event{};
UR_CHECK_ERROR(cuEventCreate(&Event, CU_EVENT_DEFAULT));
UR_CHECK_ERROR(
cuGraphAddEventRecordNode(&SignalNode, CudaGraph, &DepNode, 1, Event));
Expand Down Expand Up @@ -1433,7 +1433,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferUpdateSignalEventExp(
return UR_RESULT_ERROR_INVALID_OPERATION;
}

CUevent SignalEvent;
CUevent SignalEvent{};
UR_CHECK_ERROR(cuGraphEventRecordNodeGetEvent(SignalNode, &SignalEvent));

if (phEvent) {
Expand Down
2 changes: 1 addition & 1 deletion source/adapters/cuda/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceCreateWithNativeHandle(
ur_result_t UR_APICALL urDeviceGetGlobalTimestamps(ur_device_handle_t hDevice,
uint64_t *pDeviceTimestamp,
uint64_t *pHostTimestamp) {
CUevent Event;
CUevent Event{};
ScopedContext Active(hDevice);

if (pDeviceTimestamp) {
Expand Down
2 changes: 1 addition & 1 deletion source/adapters/cuda/platform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ urPlatformGet(ur_adapter_handle_t *, uint32_t, uint32_t NumEntries,
UR_CHECK_ERROR(cuDevicePrimaryCtxRetain(&Context, Device));

ScopedContext Active(Context); // Set native ctx as active
CUevent EvBase;
CUevent EvBase{};
UR_CHECK_ERROR(cuEventCreate(&EvBase, CU_EVENT_DEFAULT));

// Use default stream to record base event counter
Expand Down
Loading