Add size validation for USM device/shared allocs #2557
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
conformance
RossBrunton
force-pushed
the
ross/usmsize
branch
4 times, most recently
from
90776d2 to
a57191a
Compare
|
I don't think we can reliably have this check due to limitations in how the different adapters report max alloc size. |
What do you mean? The spec says that |
RossBrunton
force-pushed
the
ross/usmsize
branch
from
a57191a to
fec53b0
Compare
The spec states that an allocation size higher than `DEVICE_INFO_MAX_MEM_ALLOC_SIZE` should report an error. This has been added to the Cuda, Hip and Native CPU backends now. The tests have also been updated, which sadly introduces a new regression for level zero.
RossBrunton
force-pushed
the
ross/usmsize
branch
from
fec53b0 to
5f12d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec states that an allocation size higher than
DEVICE_INFO_MAX_MEM_ALLOC_SIZEshould report an error. This has beenadded to the cuda, hip and native cpu backends now.
The tests have also been updated, which sadly introduces a new
regression for level zero.