Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move urMemImageGetInfo success test from a switch to individual test #2549

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Move urMemImageGetInfo success test from a switch to individual test #2549

merged 1 commit into from
Jan 24, 2025

Conversation

martygrant
Copy link
Contributor

@martygrant martygrant commented Jan 13, 2025 •
edited
Loading

For #2290

Also adds a few missing enums to the ur_image_info_t struct

intel/llvm#16655

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification opencl OpenCL adapter specific issues labels Jan 13, 2025
@martygrant martygrant mentioned this pull request Jan 13, 2025
Open
14 tasks
@martygrant martygrant force-pushed the martin/memimage-info-unswitch branch 4 times, most recently from 12d5909 to 573b206 Compare January 15, 2025 16:53
@martygrant martygrant mentioned this pull request Jan 16, 2025
Merged
@martygrant martygrant marked this pull request as ready for review January 16, 2025 09:03
@martygrant martygrant requested review from a team as code owners January 16, 2025 09:03
@martygrant martygrant force-pushed the martin/memimage-info-unswitch branch from 573b206 to 78cbc49 Compare January 17, 2025 17:30
isaacault
isaacault reviewed Jan 20, 2025
View reviewed changes
test/conformance/memory/urMemImageGetInfo.cpp Outdated Show resolved Hide resolved
test/conformance/memory/urMemImageGetInfo.cpp Outdated Show resolved Hide resolved
test/conformance/memory/urMemImageGetInfo.cpp Outdated Show resolved Hide resolved
test/conformance/memory/urMemImageGetInfo.cpp Outdated Show resolved Hide resolved
source/adapters/opencl/memory.cpp Outdated Show resolved Hide resolved
@martygrant martygrant force-pushed the martin/memimage-info-unswitch branch 2 times, most recently from 1be3da7 to 6a8bda6 Compare January 22, 2025 15:26
kbenzie
kbenzie approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need to delete the match file

test/conformance/memory/memory_adapter_level_zero.match Outdated Show resolved Hide resolved
@martygrant martygrant force-pushed the martin/memimage-info-unswitch branch from 6a8bda6 to 50bda79 Compare January 22, 2025 16:57
@martygrant
Move urMemImageGetInfo success test from a switch to individual test.
707bcde 
Added implementation details to OpenCL adapter for processing image format structs.
Added a couple missing enums to spec for ur_image_info_t and added CTS tests for these.
@martygrant martygrant force-pushed the martin/memimage-info-unswitch branch from eb75d0a to 707bcde Compare January 24, 2025 10:01
@martygrant martygrant merged commit f85255e into oneapi-src:main Jan 24, 2025
26 checks passed
This was referenced Jan 24, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacault isaacault isaacault left review comments

@kbenzie kbenzie kbenzie approved these changes

Assignees
No one assigned
Labels
conformance Conformance test suite issues. loader Loader related feature/bug opencl OpenCL adapter specific issues specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martygrant @kbenzie @isaacault