Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CONTEXT_INFO_ATOMIC queries. #2374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove CONTEXT_INFO_ATOMIC queries. #2374

wants to merge 1 commit into from

Conversation

aarongreig
Copy link
Contributor

These were used as dummy values in the sycl runtime to implement meta-queries for each device in the given context. The affiliated LLVM change for this PR updates that to use __SYCL_TRAIT_HANDLED_IN_RT instead.

Fixes #2119

@aarongreig
Copy link
Contributor Author

LLVM PR intel/llvm#16160

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Nov 22, 2024
@aarongreig aarongreig force-pushed the aaron/removeContextAtomicQueries branch from 0a8855e to 76d8873 Compare November 25, 2024 16:26
@aarongreig aarongreig marked this pull request as ready for review November 25, 2024 16:27
@aarongreig aarongreig requested review from a team as code owners November 25, 2024 16:27
@aarongreig aarongreig requested a review from jchlanda November 25, 2024 16:27
jchlanda
jchlanda approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jchlanda jchlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cuda/HIP lgtm 👍

nrspruit
nrspruit approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L0 changes LGTM

@aarongreig aarongreig force-pushed the aaron/removeContextAtomicQueries branch from 76d8873 to 855a4d1 Compare January 22, 2025 12:14
@aarongreig
Remove CONTEXT_INFO_ATOMIC queries.
f3fdd84 
These were used as dummy values in the sycl runtime to implement
meta-queries for each device in the given context. The affiliated LLVM
change for this PR updates that to use __SYCL_TRAIT_HANDLED_IN_RT
instead.

Fixes oneapi-src#2119
@aarongreig aarongreig force-pushed the aaron/removeContextAtomicQueries branch from 855a4d1 to f3fdd84 Compare February 4, 2025 15:42
@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchlanda jchlanda jchlanda approved these changes

@hvdijk hvdijk hvdijk approved these changes

@kbenzie kbenzie kbenzie approved these changes

@nrspruit nrspruit nrspruit approved these changes

@martygrant martygrant martygrant approved these changes

Assignees
No one assigned
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CONTEXT_INFO_ATOMIC_ queries.
6 participants
@aarongreig @jchlanda @hvdijk @kbenzie @nrspruit @martygrant